Skip to content

feat: Added support for openshift-ai-addon version 417 and 418 #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zikra-iqbal wants to merge 13 commits into from
Closed

feat: Added support for openshift-ai-addon version 417 and 418 #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8bba66f
feat: Add support for openshift-ai-addon version 416 and 417
zikra-iqbal Nov 13, 2025
dfcab73
Merge branch 'main' into issue_16689
zikra-iqbal Nov 13, 2025
093ec68
Merge branch 'main' into issue_16689
zikra-iqbal Nov 14, 2025
851edf3
Merge branch 'main' into issue_16689
zikra-iqbal Nov 14, 2025
be836d9
Merge branch 'main' into issue_16689
Aashiq-J Nov 18, 2025
2a065b4
Merge branch 'main' into issue_16689
Khuzaima05 Nov 18, 2025
59c7eb4
added support for addons for 4.19
Nov 19, 2025
7256f33
updated error message
Nov 19, 2025
a349feb
added validation
Nov 23, 2025
e9c4239
update submodule
Nov 24, 2025
e87e2f2
Merge branch 'main' into issue_16689
Nov 27, 2025
23f5a91
resolve conflicts
Nov 27, 2025
a1ffda5
Merge branch 'main' into issue_16689
Khuzaima05 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 3 files
+1 −1 commonRenovateConfig.json
+1 −1 module-assets/ci/install-deps.sh
+8 −4 module-assets/ci/validateIbmCatalogJson.py
23 changes: 21 additions & 2 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,27 @@ variable "addons" {
default = {}

validation {
condition = (lookup(var.addons, "openshift-ai", null) != null ? lookup(var.addons["openshift-ai"], "version", null) == null : true) || (tonumber(local.ocp_version_num) >= 4.16)
error_message = "OCP AI add-on requires OCP version >= 4.16.0"
condition = (
lookup(var.addons, "openshift-ai", null) == null
|| lookup(var.addons["openshift-ai"], "version", null) == null
|| contains(["416", "417", "418"], lookup(var.addons["openshift-ai"], "version", null))
)
error_message = "Only versions 416, 417, or 418 are supported for the 'openshift-ai' add-on."
}

validation {
condition = (lookup(var.addons, "openshift-ai", null) == null) || (lookup(var.addons["openshift-ai"], "version", null) != "416") || (tonumber(local.ocp_version_num) >= 4.16 && tonumber(local.ocp_version_num) < 4.18)
error_message = "OCP AI add-on 416 requires OCP version >=4.16.0 and <4.18.0"
}

validation {
condition = (lookup(var.addons, "openshift-ai", null) == null) || (lookup(var.addons["openshift-ai"], "version", null) != "417") || (tonumber(local.ocp_version_num) >= 4.17 && tonumber(local.ocp_version_num) < 4.19)
error_message = "OCP AI add-on 417 requires OCP version >=4.17.0 and <4.19.0"
}

validation {
condition = (lookup(var.addons, "openshift-ai", null) == null) || (lookup(var.addons["openshift-ai"], "version", null) != "418") || (tonumber(local.ocp_version_num) >= 4.18 && tonumber(local.ocp_version_num) < 4.20)
error_message = "OCP AI add-on 418 requires OCP version >=4.18.0 and <4.20.0"
}

validation {
Expand Down