Skip to content

fix: add the default pool workaround to other test #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: add the default pool workaround to other test #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ func TestRunMultiClusterExample(t *testing.T) {
"module.observability_agents_1.helm_release.cloud_monitoring_agent",
"module.observability_agents_2.helm_release.log_analysis_agent",
"module.observability_agents_2.helm_release.cloud_monitoring_agent",
// workaround for the issue https://github.ibm.com/GoldenEye/issues/issues/10743
// when the issue is fixed on IKS, so the destruction of default workers pool is correctly managed on provider/clusters service the next two entries should be removed
"'module.ocp_base_cluster_1.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base_cluster_1.ibm_container_vpc_worker_pool.pool[\"default\"]'",
"'module.ocp_base_cluster_2.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base_cluster_2.ibm_container_vpc_worker_pool.pool[\"default\"]'",
},
// Do not hard fail the test if the implicit destroy steps fail to allow a full destroy of resource to occur
ImplicitRequired: false,
Expand All @@ -88,6 +94,10 @@ func TestRunAddRulesToSGExample(t *testing.T) {
ImplicitDestroy: []string{
"module.ocp_base.null_resource.confirm_network_healthy",
"module.ocp_base.null_resource.reset_api_key",
// workaround for the issue https://github.ibm.com/GoldenEye/issues/issues/10743
// when the issue is fixed on IKS, so the destruction of default workers pool is correctly managed on provider/clusters service the next two entries should be removed
"'module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base.ibm_container_vpc_worker_pool.pool[\"default\"]'",
},
// Do not hard fail the test if the implicit destroy steps fail to allow a full destroy of resource to occur
ImplicitRequired: false,
Expand All @@ -110,6 +120,10 @@ func TestCustomSGExample(t *testing.T) {
ImplicitDestroy: []string{
"module.ocp_base.null_resource.confirm_network_healthy",
"module.ocp_base.null_resource.reset_api_key",
// workaround for the issue https://github.ibm.com/GoldenEye/issues/issues/10743
// when the issue is fixed on IKS, so the destruction of default workers pool is correctly managed on provider/clusters service the next two entries should be removed
"'module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base.ibm_container_vpc_worker_pool.pool[\"default\"]'",
},
// Do not hard fail the test if the implicit destroy steps fail to allow a full destroy of resource to occur
ImplicitRequired: false,
Expand All @@ -135,6 +149,12 @@ func TestCrossKmsSupportExample(t *testing.T) {
"kms_cross_account_id": permanentResources["ge_ops_account_id"],
"ocp_version": ocpVersion3,
},
ImplicitDestroy: []string{
// workaround for the issue https://github.ibm.com/GoldenEye/issues/issues/10743
// when the issue is fixed on IKS, so the destruction of default workers pool is correctly managed on provider/clusters service the next two entries should be removed
"'module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base.ibm_container_vpc_worker_pool.pool[\"default\"]'",
},
})

output, err := options.RunTestConsistency()
Expand Down
5 changes: 4 additions & 1 deletion tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ func setupOptions(t *testing.T, prefix string, terraformDir string, ocpVersion s
"ocp_entitlement": "cloud_pak",
},
ImplicitDestroy: []string{
"module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]",
// workaround for the issue https://github.ibm.com/GoldenEye/issues/issues/10743
// when the issue is fixed on IKS, so the destruction of default workers pool is correctly managed on provider/clusters service the next two entries should be removed
"'module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool[\"default\"]'",
"'module.ocp_base.ibm_container_vpc_worker_pool.pool[\"default\"]'",
},
})

Expand Down