Skip to content

Conversation

@arya-girish-k
Copy link
Contributor

Description

Cover gaps in OCP DA

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k arya-girish-k marked this pull request as ready for review August 22, 2025 16:14
@arya-girish-k arya-girish-k changed the title fix: cover gaps in OCP DA fix: Added Missing parts in OCP DA Sep 1, 2025
@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

/run pipeline

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

upgrade test is failing @maheshwarishikha because we are changing ocp_version variable name to openshift_version so upgrade test will fail as main branch does not expect openshift_version. I will do manual testing in schematics and i will share screenshots here for both fully-configurable and upgrade test.

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

I have tested the upgrade tests locally, we do variable validation for schematics test where if some variable which is not declared in variables.tf is passed to schematics test it will fail the test saying that variable passed which is not declared in variables.tf. For local testing, i skipped that variable validation and both DA's upgrade test passed. Attaching the screenshot here and skipping the upgrade test.

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

Screenshot 2025-09-09 at 8 28 16 PM Screenshot 2025-09-09 at 8 32 40 PM

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

/run pipeline

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

running one more time as main branch has been recently updated

@vkuma17
Copy link
Contributor

vkuma17 commented Sep 9, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 119bd40 into main Sep 9, 2025
2 checks passed
@ocofaigh ocofaigh deleted the gaps-ocp branch September 9, 2025 19:52
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants