Skip to content

tests: enable event notifications for SM #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

tests: enable event notifications for SM #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cde877c
Update pr_test.go
vkuma17 Sep 29, 2025
bdaf44b
fixed precommit
vkuma17 Sep 29, 2025
a304cee
Merge branch 'main' into Vipin654-patch-1
vkuma17 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "go.sum|^.secrets.baseline$",
"lines": null
},
"generated_at": "2025-09-05T15:37:15Z",
"generated_at": "2025-09-29T09:18:41Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -82,7 +82,7 @@
"hashed_secret": "8196b86ede820e665b2b8af9c648f4996be99838",
"is_secret": false,
"is_verified": false,
"line_number": 91,
"line_number": 90,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down
18 changes: 0 additions & 18 deletions tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"strings"
"testing"

"github.com/IBM/go-sdk-core/core"
"github.com/gruntwork-io/terratest/modules/files"
"github.com/gruntwork-io/terratest/modules/logger"
"github.com/gruntwork-io/terratest/modules/random"
Expand Down Expand Up @@ -270,23 +269,6 @@ func TestRoksAddonDefaultConfiguration(t *testing.T) {
},
)

/*
Secrets manager is manually disabled in this test because it deploys Event notification
and event notifications DA creates kms keys and during undeploy the order of key protect and event notifications
is not considered by projects as EN is not a direct dependency of OCP DA. So undeploy fails, because
key protect instance can't be deleted because of active keys created by EN. Hence for now, we don't want to deploy
EN so SM is being disabled.
Issue has been created for projects team. https://github.ibm.com/epx/projects/issues/4750
Once that is fixed, we can remove the logic to disable SM
*/
options.AddonConfig.Dependencies = []cloudinfo.AddonConfig{
{
OfferingName: "deploy-arch-ibm-secrets-manager",
OfferingFlavor: "fully-configurable",
Enabled: core.BoolPtr(false), // explicitly disabled
},
}

err := options.RunAddonTest()
require.NoError(t, err)
}
Expand Down