Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Sep 18, 2025

Description

DEPENDS ON: terraform-ibm-modules/terraform-ibm-event-notifications#554

  • Updated to latest DA dependency versions
  • I added Event Notifications as a dependnat DA (however the mapping of the instance CRN is still blocked due to project bug thats being looked at)
  • Fixed typos
  • Cleanup tests (we already test fully configurable DA in the addons test and security enforced test (since its a wrapper around fully configurable) so no need to duplicate the test)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh marked this pull request as ready for review September 18, 2025 19:38
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

Looks like some network issues when trying to pull from terraform registry:

 2025/09/18 20:29:36 Terraform init | Error: Error accessing remote module registry
 2025/09/18 20:29:36 Terraform init | 
 2025/09/18 20:29:36 Terraform init |   on main.tf line 5:
 2025/09/18 20:29:36 Terraform init |    5: module "resource_group" {
 2025/09/18 20:29:36 Terraform init | 
 2025/09/18 20:29:36 Terraform init | Failed to retrieve available versions for module "resource_group" (main.tf:5)
 2025/09/18 20:29:36 Terraform init | from registry.terraform.io: the request failed after 2 attempts, please try
 2025/09/18 20:29:36 Terraform init | again later: Get
 2025/09/18 20:29:36 Terraform init | "https://registry.terraform.io/v1/modules/terraform-ibm-modules/resource-group/ibm/versions":
 2025/09/18 20:29:36 Terraform init | net/http: request canceled (Client.Timeout exceeded while awaiting headers).
 2025/09/18 20:29:36 Terraform init | 
 2025/09/18 20:29:36 Terraform init | Error: Error accessing remote module registry
 2025/09/18 20:29:36 Terraform init | 
 2025/09/18 20:29:36 Terraform init |   on main.tf line 356:
 2025/09/18 20:29:36 Terraform init |  356: module "secrets_manager_service_credentials" {
 2025/09/18 20:29:36 Terraform init | 
 2025/09/18 20:29:36 Terraform init | Failed to retrieve available versions for module
 2025/09/18 20:29:36 Terraform init | "secrets_manager_service_credentials" (main.tf:356) from
 2025/09/18 20:29:36 Terraform init | registry.terraform.io: the request failed after 2 attempts, please try again
 2025/09/18 20:29:36 Terraform init | later: Get
 2025/09/18 20:29:36 Terraform init | "https://registry.terraform.io/v1/modules/terraform-ibm-modules/secrets-manager/ibm/versions":
 2025/09/18 20:29:36 Terraform init | net/http: request canceled (Client.Timeout exceeded while awaiting headers).

Retrying..

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 2e338a7 into main Sep 19, 2025
2 checks passed
@ocofaigh ocofaigh deleted the tests branch September 19, 2025 09:44
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.6.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants