Add account settings variation

[iamar7]

Description

Add Metrics Router Account Settings variation

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[iamar7]

/run pipeline

[arya-girish-k]

/run pipeline

[shemau]

I am failing to understand why this is a different DA and not included in the fully configurable DA. There seem to be routes, targets and settings. Why are only routes and targets set up in one, and only settings in the other. All three resources seem to be conceptually linked.

I am not sure if this is the right question, but why doesn't fully configurable, as the name suggests duplicate this function? Was the plan to add this at the project level later (dependancies, add-ons etc)?

[arya-girish-k]

I am failing to understand why this is a different DA and not included in the fully configurable DA. There seem to be routes, targets and settings. Why are only routes and targets set up in one, and only settings in the other. All three resources seem to be conceptually linked.

I am not sure if this is the right question, but why doesn't fully configurable, as the name suggests duplicate this function? Was the plan to add this at the project level later (dependancies, add-ons etc)?

@shemau :This is a request from observability team .Please find the discussion and the related issue for your reference.

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[ocofaigh]

see comments

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[ocofaigh]

final few comments

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[vkuma17]

/run pipeline

[ocofaigh]

@arya-girish-k We will keep seeing this error due to tests conflicting with each other. It is probably safe to add this to the ignore update list in the test so we don't have regular conflicting tests:

       	Messages:   	Resource(s) identified to be updated 
        	            	Name: metrics_router_settings
        	            	Address: module.metrics_routing[0].ibm_metrics_router_settings.metrics_router_settings[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"primary_metadata_region":"eu-de"}
        	            	  After: 
        	            		{"primary_metadata_region":"eu-fr2"}

[arya-girish-k]

/run pipeline

[arya-girish-k]

@arya-girish-k We will keep seeing this error due to tests conflicting with each other. It is probably safe to add this to the ignore update list in the test so we don't have regular conflicting tests:

       	Messages:   	Resource(s) identified to be updated 
        	            	Name: metrics_router_settings
        	            	Address: module.metrics_routing[0].ibm_metrics_router_settings.metrics_router_settings[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"primary_metadata_region":"eu-de"}
        	            	  After: 
        	            		{"primary_metadata_region":"eu-fr2"}

Added ignoreupdate list in the test

[arya-girish-k]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

• GitHub release
• v1.5.0

Your semantic-release bot 📦🚀

[ocofaigh]

@arya-girish-k I just noticed you never added the IgnoreUpdates here - I suspect this will eventually fail due to same issue