Skip to content

Conversation

@kierramarie
Copy link
Member

@kierramarie kierramarie commented Jul 8, 2025

Description

Bump terraform helm version to v3 and update code to support changes.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Member Author

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

@vbontempi
Copy link
Member

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

Errors"

        	Error:      	Should be false
        	Test:       	TestRunFullConfigSolutionUpgradeSchematics
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: external_secret_store_apikey
        	            	Address: module.eso_secretsstore["ss-1"].helm_release.external_secret_store_apikey[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"id":"eso-namespace-ss1-ss-1-helmrelease","metadata":{"app_version":"","chart":"raw","first_deployed":1753825726,"last_deployed":1753825726,"name":"eso-namespace-ss1-ss-1-helmrelease","namespace":"eso-namespace-ss1","notes":"","revision":1,"values":"SECURE_VALUE_HIDDEN_HASH:-a2265f9b91cbc0db9870a42b47282531fc27492b0a92831e42300519","version":"v0.2.5"},"postrender":"SECURE_VALUE_HIDDEN_HASH:-3c87ce287244d87da461bc436c385b4357bfa44c24e28dbf1d746477","set":"SECURE_VALUE_HIDDEN_HASH:-a6d0e710e63146a6527b97717f2089948f93a3bbbb885d86c6019819","set_list":"SECURE_VALUE_HIDDEN_HASH:-946de436f5d96173384fcdb29d11b444a9926a8f27517c587df06a7a","set_sensitive":"SECURE_VALUE_HIDDEN_HASH:-02344917d73289c2dcfa523e4122a9e2ffe0615462694bf751e0b417","set_wo_revision":1,"version":"v0.2.5"}
        	            	  After: 
        	            		{"postrender":"SECURE_VALUE_HIDDEN_HASH:-aafac791e843251cd2c80dd118bf864e506525338daea1de2a5f2daa","set":"SECURE_VALUE_HIDDEN_HASH:-df3f38203f620ab351e0d058ae63e858642e8372197544b7374d19a4","set_list":"SECURE_VALUE_HIDDEN_HASH:-3e44b8076e7a1170962fc452a5388502d9cf204b62835a3df31d6643","set_sensitive":"SECURE_VALUE_HIDDEN_HASH:-f7f566dccac5b48bef63428a13cf63ac734981bdf17c40219eb31312","set_wo_revision":null,"version":"0.2.5"}
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │       "Result": {
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │           "errors": [
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │               {
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │                   "code": "bad_request",
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │                   "message": "The certificate can't be added because it is expired. Try again with a valid certificate. [secrets-manager.05063E]",
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │                   "more_info": "https://cloud.ibm.com/apidocs/secrets-manager"
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │               }
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │           ],
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │           "status_code": 400,
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │           "trace": "14baa40c-c53f-81a7-1a3e-d3fc65e85413"
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │       },
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │       "RawResult": null
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   }
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ severity: error
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ resource: ibm_sm_imported_certificate
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ operation: create
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ component:
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   version: 1.80.3
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ ---
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ 
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │ 
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   with ibm_sm_imported_certificate.secrets_manager_imported_certificate[0],
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   on importedcertificate.tf line 28, in resource "ibm_sm_imported_certificate" "secrets_manager_imported_certificate":
TestRunUpgradeExample 2025-07-29T22:51:58Z logger.go:67: │   28: resource "ibm_sm_imported_certificate" "secrets_manager_imported_certificate" {

^^ also in default example

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests are ok, checks on deployed resources are ok, checks on upgraded deployments are ok

@vbontempi
Copy link
Member

renovate PR waiting on this #169

@vburckhardt
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit 7053ef8 into main Aug 12, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ks-helmv3 branch August 12, 2025 07:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants