Skip to content

Conversation

@anbunithi-dev
Copy link
Collaborator

Fix multi-profile image config, rename Atracker test, add COS/logs test, enhance LDAP invalid cases

@anbunithi-dev
Copy link
Collaborator Author

Checkov...................................................................Passed
Forbid binaries.......................................(no files to check)Skipped
Test shell scripts with shellcheck........................................Passed
go fmt....................................................................Passed
Detect secrets............................................................Passed
flake8....................................................................Passed
isort.....................................................................Passed
black.....................................................................Passed
golangci-lint.............................................................Passed
Add examples section to README............................................Passed
Add terraform docs section to README......................................Passed
Add overview section to README............................................Passed
Validate catalogValidationValues.json.template file.......................Passed
Add module repository to go.mod...........................................Passed
Validate ibm_catalog.json file............................................Passed
helmlint..................................................................Passed
Validate ibm_catalog.json schema..........................................Passed

@sumansuhag
Copy link

Does a vague commit message that covers several unrelated fixes in one pull request increase the chances of missing bugs or causing unexpected problems? When you combine different changes—like UI tweaks, image setups, and updates to testing and authentication—without explaining each one or how they were tested, it can make code reviews tougher. This approach might also complicate future debugging and mask the real effects of the changes made. It seems like it favors merging quickly over keeping commits clear and manageable, which is important for keeping software reliable and easy to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants