Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Oct 21, 2024

Description

Update KMS all inclusive which removes key ring force delete because it is deprecated by the provider

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from imprateeksh as a code owner October 21, 2024 12:59
@shemau
Copy link
Contributor Author

shemau commented Oct 21, 2024

The expectation is that this PR will need to skip upgrade test because of the key ring force delete state change. The changes are in example code, not the main module, so no release is required.

@shemau
Copy link
Contributor Author

shemau commented Oct 21, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 21, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 21, 2024

TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185:   ~ resource "ibm_kms_key_rings" "key_ring" {
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185:       ~ force_delete  = true -> false
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185:         id            = "icd-edb:keyRing:crn:v1:bluemix:public:kms:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:0e055927-e36c-4859-a449-f99faaf53f80::"
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185:         # (3 unchanged attributes hidden)
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185:     }

As expected, the value in the example is seen to change, which breaks update. This was the only error, so skipping upgrade.

@shemau
Copy link
Contributor Author

shemau commented Oct 21, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 22, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 1972572 into main Oct 22, 2024
2 checks passed
@ocofaigh ocofaigh deleted the force-delete-ring branch October 22, 2024 21:45
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.8.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants