This repository was archived by the owner on Jun 17, 2025. It is now read-only.
generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(deps): bump KMS with code change #275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The expectation is that this PR will need to skip upgrade test because of the key ring force delete state change. The changes are in example code, not the main module, so no release is required. |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185: ~ resource "ibm_kms_key_rings" "key_ring" {
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185: ~ force_delete = true -> false
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185: id = "icd-edb:keyRing:crn:v1:bluemix:public:kms:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:0e055927-e36c-4859-a449-f99faaf53f80::"
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185: # (3 unchanged attributes hidden)
TestRunUpgradeCompleteExample 2024-10-21T16:19:11Z command.go:185: }As expected, the value in the example is seen to change, which breaks update. This was the only error, so skipping upgrade. |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
MatthewLemmond
approved these changes
Oct 22, 2024
Contributor
|
🎉 This PR is included in version 1.8.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update KMS all inclusive which removes key ring force delete because it is deprecated by the provider
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers