Skip to content

fix: add count to wait #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: add count to wait #299

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80ef370
fix: add count to wait
MatthewLemmond Sep 25, 2024
8e392e2
refactor: add counts to waits in the solution
MatthewLemmond Sep 26, 2024
9d60a52
refactor: move counts for auth to locals
MatthewLemmond Sep 26, 2024
431f339
refactor: skipping upgrade test
MatthewLemmond Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ resource "ibm_iam_authorization_policy" "policy" {

# workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4478
resource "time_sleep" "wait_for_authorization_policy" {
count = var.kms_encryption_enabled == false || var.skip_iam_authorization_policy ? 0 : 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this now has a count, does the depends_on on line 56 need to be updated?

Copy link
Contributor

@ocofaigh ocofaigh Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating line 38 and 48, suggest to use a local (incase the logic is ever updated, it would only need to be changed in 1 place)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this now has a count, does the depends_on on line 56 need to be updated?

No, when doing depends on we don't do any indexing or anything like that so it passes as is and is still necessary

depends_on = [ibm_iam_authorization_policy.policy]

create_duration = "30s"
Expand Down