Update cra target and supported versions #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
ocofaigh
reviewed
Oct 25, 2024
ocofaigh
requested changes
Oct 25, 2024
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Oct 25, 2024
cra-config.yaml
Outdated
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json` | ||
| PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile). | ||
| CRA_ENVIRONMENT_VARIABLES: | ||
| TF_VAR_existing_at_instance_crn: "crn:v1:bluemix:public:logdnaat:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:b1ef3365-dfbf-4d8f-8ac8-75f4f84d6f4a::" |
cra-config.yaml
Outdated
| PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile). | ||
| CRA_ENVIRONMENT_VARIABLES: | ||
| TF_VAR_existing_at_instance_crn: "crn:v1:bluemix:public:logdnaat:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:b1ef3365-dfbf-4d8f-8ac8-75f4f84d6f4a::" | ||
| TF_VAR_existing_kms_instance_guid: "e6dce284-e80f-46e1-a3c1-830f7adff7a9" |
There was a problem hiding this comment.
the input for the DA is existing_kms_instance_crn
ocofaigh
reviewed
Oct 25, 2024
|
/run pipeline |
|
@daniel-butler-irl still some open comments on the CRA config above |
|
/run pipeline |
ocofaigh
reviewed
Oct 25, 2024
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
retrying seemed to be some kind of timeout... |
…in a code engine project. To enable, set `enable_kibana_dashboard` to `true` (#309)
Co-authored-by: Conall Ó Cofaigh <[email protected]>
…mly generated keys for disk and backups encryption in the fscloud submodule, and the DA using new input `use_ibm_owned_encryption_key`<br>* Exposed the ability to set the IBM terraform provider visability in the DA using new input `provider_visibility` ([Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/guides/custom-service-endpoints))<br>* updated the scope of the KMS auth policy that is created so the policy is now scoped to the exact KMS key. If upgrading from a previous version, this will destroy the old policy, however the new one will be created before its destroyed to ensure no impact to every day services.<br>* Fixed an issue in the original ICD hosting model logic for conditionally including the group block during a database restore operation (#330)
- Update terraform-ibm-modules/cbr/ibm to v1.28.1 - Update required provider version to >= 1.70.0 to pick up the fix for this provider issue: [ibm_cbr_zone] Error: Provider produced inconsistent result after apply IBM-Cloud/terraform-provider-ibm#5590
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update CRA target and supported versions
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
8.15Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers