Skip to content

Conversation

@Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented May 24, 2025

Description

This PR covers several security issues-

  • Setting up built-in kibana_system user password specifically for the Code Engine Kibana application to connect to Elasticsearch instance with reduced permissions.
  • Creates a new user for the Kibana application with database role.
  • Set CBR rule for the Kibana dashboard using cbr_code_engine_kibana_project_rules variable.

Git Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Implements secure Kibana authentication by configuring built-in kibana_system user password and creating database-role users for dashboard access, plus adds CBR rules for Code Engine Kibana app integration using cbr_code_engine_kibana_project_rules variable.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky changed the title feat: Added feature to CBR for Kibana app feat: Added feature to add CBR for Kibana app and other secrity issues May 24, 2025
@Ak-sky
Copy link
Member Author

Ak-sky commented May 24, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented May 24, 2025

/run pipeline

@Ak-sky Ak-sky changed the title feat: Added feature to add CBR for Kibana app and other secrity issues feat: Added feature to add CBR for Kibana app and other security issues May 24, 2025
@Ak-sky
Copy link
Member Author

Ak-sky commented May 29, 2025

/run pipeline

3 similar comments
@Ak-sky
Copy link
Member Author

Ak-sky commented May 29, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented May 29, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented May 30, 2025

/run pipeline

@github-actions
Copy link

@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky
Copy link
Member Author

Ak-sky commented May 30, 2025

/run pipeline

@github-actions
Copy link

@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky
Copy link
Member Author

Ak-sky commented May 30, 2025

/run pipeline

@github-actions
Copy link

@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky Ak-sky requested a review from ocofaigh June 3, 2025 09:17
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced this will work as expected.

Are there any tests to cover/validate the new feature?

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small feedback

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 6, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 20, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 22, 2025

Test failing with-, investigating

        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/terraform.go:252
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testschematic/tests.go:28
        	            				/__w/terraform-ibm-icd-elasticsearch/terraform-ibm-icd-elasticsearch/tests/pr_test.go:124
        	Error:      	Should be false
        	Test:       	TestRunFullyConfigurableSolutionSchematics
        	Messages:   	Resource(s) identified to be created 
        	            	Name: set_kibana_system_user_password
        	            	Address: restapi_object.set_kibana_system_user_password[0]
        	            	Actions: [create]
        	            	DIFF:
        	            	Error getting diff: 'before' value is not an object

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 23, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 24, 2025

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 24, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 27, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 30, 2025

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 30, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jul 30, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Aug 4, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Aug 4, 2025

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemau
Copy link
Contributor

shemau commented Aug 7, 2025

/run pipeline

@daniel-butler-irl daniel-butler-irl merged commit 1a2952c into main Aug 7, 2025
2 checks passed
@daniel-butler-irl daniel-butler-irl deleted the kibana_system branch August 7, 2025 13:11
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants