- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
feat: Added feature to add CBR for Kibana app and other security issues #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
    
      
        3 similar comments
      
    
  
    | /run pipeline | 
| /run pipeline | 
| /run pipeline | 
| @Ak-sky you must be in the team github-collaborators in order to trigger the pipeline. | 
| /run pipeline | 
| @Ak-sky you must be in the team github-collaborators in order to trigger the pipeline. | 
| /run pipeline | 
| @Ak-sky you must be in the team github-collaborators in order to trigger the pipeline. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced this will work as expected.
Are there any tests to cover/validate the new feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some small feedback
| /run pipeline | 
| /run pipeline | 
| Test failing with-, investigating  | 
| /run pipeline | 
| /run pipeline | 
    
      
        1 similar comment
      
    
  
    | /run pipeline | 
| /run pipeline | 
| /run pipeline | 
    
      
        1 similar comment
      
    
  
    | /run pipeline | 
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| /run pipeline | 
| 🎉 This PR is included in version 2.3.0 🎉 The release is available on: 
 Your semantic-release bot 📦🚀 | 
Description
This PR covers several security issues-
kibana_systemuser password specifically for the Code Engine Kibana application to connect to Elasticsearch instance with reduced permissions.databaserole.cbr_code_engine_kibana_project_rulesvariable.Git Issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
kibana_systemuser password and creating database-role users for dashboard access, plus adds CBR rules for Code Engine Kibana app integration usingcbr_code_engine_kibana_project_rulesvariable.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers