Skip to content

feat: add workaround for groups #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2024
Merged

feat: add workaround for groups #443

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ec9084
feat: add workaround for groups
Nov 21, 2024
c70c376
Update main.tf
jor2 Nov 21, 2024
76518a9
Update main.tf
jor2 Nov 21, 2024
3421449
Merge branch 'main' into group-fix
jor2 Nov 25, 2024
939bda8
fix: if condition
Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ resource "ibm_database" "mongodb" {
## This is used to conditionally add one, OR, the other group block depending on var.local.host_flavor_set
## This block is for if host_flavor IS set to specific pre-defined host sizes and not set to "multitenant"
dynamic "group" {
for_each = local.host_flavor_set && var.member_host_flavor != "multitenant" ? [1] : []
for_each = local.host_flavor_set && var.member_host_flavor != "multitenant" && var.backup_crn == null ? [1] : []
content {
group_id = "member" # Only member type is allowed for IBM Cloud Databases
host_flavor {
Expand All @@ -97,7 +97,7 @@ resource "ibm_database" "mongodb" {

## This block is for if host_flavor IS set to "multitenant"
dynamic "group" {
for_each = local.host_flavor_set && var.member_host_flavor == "multitenant" ? [1] : []
for_each = local.host_flavor_set && var.member_host_flavor == "multitenant" && var.backup_crn == null ? [1] : []
content {
group_id = "member" # Only member type is allowed for IBM Cloud Databases
host_flavor {
Expand All @@ -120,7 +120,7 @@ resource "ibm_database" "mongodb" {

## This block is for if host_flavor IS NOT set
dynamic "group" {
for_each = local.host_flavor_set ? [] : [1]
for_each = local.host_flavor_set && var.backup_crn == null ? [] : [1]
Copy link
Contributor

@shemau shemau Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That logic was wrong and later improved in postgresql to:

for_each = local.host_flavor_set == false && !local.recovery_mode ? [1] : []

Without pitr I think it needs to be

for_each = local.host_flavor_set == false && !var.backup_crn ? [1] : []

content {
group_id = "member" # Only member type is allowed for IBM Cloud Databases
memory {
Expand Down Expand Up @@ -178,6 +178,8 @@ resource "ibm_database" "mongodb" {

timeouts {
create = "120m" # Extending provisioning time to 120 minutes
update = "120m"
delete = "15m"
}
}

Expand Down