Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 16, 2025

Description

add logic around refactoring kms and added da. removed configuration variable as it is not supported https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database#configuration-1

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 16, 2025
@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

2 similar comments
@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

2 similar comments
@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 17, 2025

/run pipeline

@jor2 jor2 requested a review from ocofaigh January 17, 2025 13:45
@ocofaigh ocofaigh merged commit eb2a86a into main Jan 17, 2025
2 checks passed
@ocofaigh ocofaigh deleted the kms-refactor branch January 17, 2025 18:29
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants