Skip to content

fix: comments in examples #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

fix: comments in examples #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bad84b
fix: comments in examples
shemau May 16, 2025
44975e9
Merge branch 'main' into example-comments
shemau May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/backup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ data "ibm_database_backups" "backup_database" {

# New mysql instance pointing to the backup instance
module "restored_mysql_db" {
source = "../.."
source = "../.."
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-mysql-restored"
mysql_version = var.mysql_version
Expand Down
12 changes: 9 additions & 3 deletions examples/basic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ module "resource_group" {
##############################################################################

module "database" {
source = "../.."
source = "../.."
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-mysql"
mysql_version = var.mysql_version
Expand Down Expand Up @@ -51,8 +54,11 @@ resource "time_sleep" "wait_time" {
##############################################################################

module "read_only_replica_mysql_db" {
count = var.read_only_replicas_count
source = "../.."
count = var.read_only_replicas_count
source = "../.."
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-read-only-replica-${count.index}"
region = var.region
Expand Down
5 changes: 4 additions & 1 deletion examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ module "cbr_zone" {
##############################################################################

module "mysql_db" {
source = "../../"
source = "../../"
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-mysql"
region = var.region
Expand Down
5 changes: 4 additions & 1 deletion examples/fscloud/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ module "cbr_zone" {
##############################################################################

module "mysql" {
source = "../../modules/fscloud"
source = "../../modules/fscloud"
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm//modules/fscloud"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-mysql"
region = var.region
Expand Down
5 changes: 4 additions & 1 deletion examples/pitr/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ module "resource_group" {

# New ICD mysql database instance pointing to a PITR time
module "mysql_db_pitr" {
source = "../.."
source = "../.."
# remove the above line and uncomment the below 2 lines to consume the module from the registry
# source = "terraform-ibm-modules/icd-mysql/ibm"
# version = "X.Y.Z" # Replace "X.Y.Z" with a release version to lock into a specific release
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-mysql-pitr"
region = var.region
Expand Down