Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Jul 1, 2025

Description

Fixes for recent test failure during renovate PR pipelines

  1. Upgrade test to include fully configurable
  2. Remove existing_backup_kms_key_crn which results in duplicate auth key

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested review from Ak-sky and toddgiguere as code owners July 1, 2025 15:43
@shemau
Copy link
Contributor Author

shemau commented Jul 1, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 2, 2025

Failing with duplicate auth policy. Re-trying whilst investigating.

@shemau
Copy link
Contributor Author

shemau commented Jul 2, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 3, 2025

The issue is two identical policies based on a shared key:

2025/07/02 10:37:45 Terraform apply | # module.mysql.module.mysql[0].ibm_iam_authorization_policy.backup_kms_policy[0] will be created

2025/07/02 10:37:45 Terraform apply | # module.mysql.module.mysql[0].ibm_iam_authorization_policy.kms_policy[0] will be created

@shemau
Copy link
Contributor Author

shemau commented Jul 3, 2025

/run pipeline

@toddgiguere toddgiguere merged commit b5ca661 into main Jul 3, 2025
2 checks passed
@toddgiguere toddgiguere deleted the fix-tests branch July 3, 2025 17:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants