-
Notifications
You must be signed in to change notification settings - Fork 2
fix: workaround group on restore #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
| ## This block is for if host_flavor IS set to specific pre-defined host sizes and not set to "multitenant" | ||
| dynamic "group" { | ||
| for_each = local.host_flavor_set && var.member_host_flavor != "multitenant" ? [1] : [] | ||
| for_each = local.host_flavor_set && var.member_host_flavor != "multitenant" && var.backup_crn == null ? [1] : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this may prevent scaling after restoring from a backup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restore from backup is a one time operation.
In order to scale after restoring from backup, the process should (must) pass null in the backup_crn. This would restore the group block (per previous behaviour).
make run-tests-local RUN=TestRunRestoredDBExamplewas run locally and passed. This was done to cover the backup/restore test which does not run as part of the PR validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per ICD team, we need to update the timeout value for update. They suggest this:
timeouts {
create = "120m"
update = "120m"
delete = "15m"
}
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 3.17.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add a work around to remove the
groupblock when restoring from a backup.Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Avoid defining the host_flavor during restore operations.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers