Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Nov 6, 2024

Description

Following on from #508 and #512, remove the wal_level is being hidden.

Consumers can still set a value, since the field is still present and optional.
The default values no longer set wal_level and the validation is removed.

This PR will need revert / updating when the service changes are deployed

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Nov 6, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 6, 2024

@shemau I think upgrade test will fail (since main branch DA code is broken)

condition = var.configuration != null ? (var.configuration["wal_level"] != null ? contains(["replica", "logical"], var.configuration["wal_level"]) : true) : true
error_message = "Value for `configuration[\"wal_level\"]` must be either `replica` or `logical`, if specified."
}
# skip validation for issue #508 and #512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to link to #512

@shemau
Copy link
Contributor Author

shemau commented Nov 6, 2024

Upgrade fails

TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66:"Result": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66:"errors": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66:"configuration.wal_level": [
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66:"must be one of: hot_standby, logical"
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │             ]
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │         }
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │     },

Because the base branch is broken. No other errors, so skipping upgrade.

@shemau
Copy link
Contributor Author

shemau commented Nov 6, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 6, 2024

Timeout (reported to ICD). Retrying to see if it was a once off..

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 6, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Nov 6, 2024

The test that failed this run passed the first time...

TestRunBasicExampleWithFlavor 2024-11-06T15:14:04Z logger.go:66: module.read_only_replica_postgresql_db[0].ibm_database.postgresql_db: Creation complete after 7m52s [id=crn:v1:bluemix:public:databases-for-postgresql:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:f267af9b-bded-4543-aa27-9b6ddad6bde7::]

So I am just going to try again. (Oh my page just updated... it was already restarted... so I will follow that)

@ocofaigh ocofaigh merged commit 97a9f96 into main Nov 7, 2024
2 checks passed
@ocofaigh ocofaigh deleted the skip-wal-level branch November 7, 2024 08:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.17.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants