Skip to content

fix: remove wal_level default values and validation #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: remove wal_level default values and validation #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a475c71
fix: remove wal_level default values and validation
shemau Nov 6, 2024
0007363
SKIP UPGRADE TEST
shemau Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ module "postgresql_db" {
tcp_keepalives_interval = 50
tcp_keepalives_count = 6
archive_timeout = 1000
wal_level = "replica"
max_replication_slots = 10
max_wal_senders = 20
}
Expand Down
1 change: 0 additions & 1 deletion solutions/standard/DA-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ The following example shows values for the `configuration` input.
"tcp_keepalives_interval": 15,
"tcp_keepalives_count": 6,
"archive_timeout": 1800,
"wal_level": "replica",
"max_replication_slots": 10,
"max_wal_senders": 12
}
Expand Down
1 change: 0 additions & 1 deletion solutions/standard/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ variable "configuration" {
tcp_keepalives_interval = 15
tcp_keepalives_count = 6
archive_timeout = 1800
wal_level = "replica"
max_replication_slots = 10
max_wal_senders = 12
}
Expand Down
9 changes: 5 additions & 4 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,11 @@ variable "configuration" {
error_message = "Value for `configuration[\"archive_timeout\"]` must be 300 or more, if specified."
}

validation {
condition = var.configuration != null ? (var.configuration["wal_level"] != null ? contains(["replica", "logical"], var.configuration["wal_level"]) : true) : true
error_message = "Value for `configuration[\"wal_level\"]` must be either `replica` or `logical`, if specified."
}
# skip validation for issue #508 and #512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to link to #512

#validation {
# condition = var.configuration != null ? (var.configuration["wal_level"] != null ? contains(["replica", "logical"], var.configuration["wal_level"]) : true) : true
# error_message = "Value for `configuration[\"wal_level\"]` must be either `replica` or `logical`, if specified."
#}

validation {
condition = var.configuration != null ? (var.configuration["max_replication_slots"] != null ? var.configuration["max_replication_slots"] >= 10 : true) : true
Expand Down