Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Nov 13, 2024

Description

Simplify the memory model used for basic testing. 4096 is the minimum size.
The multitenant other_test.go has been run and passed locally with the new lower memory.

Note: Error messages reporting 8192 (or more) are just multiplying the 4096 by the number of members.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Nov 13, 2024

/run pipeline

@shemau shemau marked this pull request as draft November 13, 2024 13:26
@ocofaigh
Copy link
Contributor

@shemau you happy to proceed?

@shemau shemau marked this pull request as ready for review November 14, 2024 11:59
@ocofaigh ocofaigh merged commit 0003266 into main Nov 14, 2024
2 checks passed
@ocofaigh ocofaigh deleted the reduce-memory branch November 14, 2024 13:28
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.19.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants