Skip to content

fix: reduce memory usage in test #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: reduce memory usage in test #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/basic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ module "postgresql_db" {
resource_tags = var.resource_tags
access_tags = var.access_tags
member_host_flavor = var.member_host_flavor
member_memory_mb = var.member_memory_mb
}

# On destroy, we are seeing that even though the replica has been returned as
Expand Down
6 changes: 0 additions & 6 deletions examples/basic/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,3 @@ variable "member_host_flavor" {
description = "Allocated host flavor per member. For more information, see https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database#host_flavor"
default = null
}

variable "member_memory_mb" {
type = number
description = "Allocated memory per-member. See the following doc for supported values: https://cloud.ibm.com/docs/databases-for-postgresql?topic=databases-for-postgresql-resources-scaling"
default = 4096
}
1 change: 0 additions & 1 deletion tests/other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func TestRunBasicExampleWithFlavorMultitenant(t *testing.T) {
ResourceGroup: resourceGroup,
TerraformVars: map[string]interface{}{
"member_host_flavor": "multitenant",
"member_memory_mb": 8192, // Requires a minimum of 8192 megabytes with multitenant flavor
},
CloudInfoService: sharedInfoSvc,
})
Expand Down