Skip to content

fix: logic when host flavour not set #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024
Merged

fix: logic when host flavour not set #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94ca79
fix: logic when host flavour not set
shemau Nov 7, 2024
d499c9e
fix: update read replica to new hosting with min spec
shemau Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions examples/basic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,17 @@ resource "time_sleep" "wait_time" {
##############################################################################

module "read_only_replica_postgresql_db" {
count = var.read_only_replicas_count
source = "../.."
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-read-only-replica-${count.index}"
region = var.region
resource_tags = var.resource_tags
access_tags = var.access_tags
pg_version = var.pg_version
remote_leader_crn = module.postgresql_db.crn
member_memory_mb = 2304 # Must be an increment of 384 megabytes. The minimum size of a read-only replica is 2 GB RAM
member_disk_mb = 15360 # Must be an increment of 512 megabytes. The minimum size of a read-only replica is 15.36 GB of disk
depends_on = [time_sleep.wait_time]
count = var.read_only_replicas_count
source = "../.."
resource_group_id = module.resource_group.resource_group_id
name = "${var.prefix}-read-only-replica-${count.index}"
region = var.region
resource_tags = var.resource_tags
access_tags = var.access_tags
pg_version = var.pg_version
remote_leader_crn = module.postgresql_db.crn
member_host_flavor = "multitenant"
member_memory_mb = 4096 # Must be an increment of 384 megabytes. The minimum size of a read-only replica is 2 GB RAM, new hosting model minimum is 4 GB RAM.
member_disk_mb = 15360 # Must be an increment of 512 megabytes. The minimum size of a read-only replica is 15.36 GB of disk
depends_on = [time_sleep.wait_time]
}
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ resource "ibm_database" "postgresql_db" {

## This block is for if host_flavor IS NOT set
dynamic "group" {
for_each = local.host_flavor_set && var.backup_crn == null ? [] : [1]
for_each = local.host_flavor_set == false && var.backup_crn == null ? [1] : []
content {
group_id = "member" # Only member type is allowed for IBM Cloud Databases
memory {
Expand Down