Conversation
|
/run pipeline |
|
@Aayush-Abhyarthi, is this covering all the scenarios like this one here- terraform-ibm-modules/terraform-ibm-icd-redis#563 (comment)? |
@Ak-sky Yes Akash. |
|
/run pipeline |
mukulpalit-ibm
left a comment
mukulpalit-ibm
left a comment
There was a problem hiding this comment.
Validation missing in root module
| var.use_same_kms_key_for_backups | ||
| ) | ||
| error_message = "When 'use_same_kms_key_for_backups' is set to false, a value needs to be passed for 'backup_encryption_key_crn'." | ||
| } |
There was a problem hiding this comment.
validation missing for validate_pitr_vars
There was a problem hiding this comment.
good catch... I added a tested commit for this.
I opted for more specific (more verbose) validation. This keeps the validation conditional logic simpler and more readable. Feel free to change it if you want.
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 3.22.19 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 participants
Description
https://github.ibm.com/GoldenEye/issues/issues/12402
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Upgrade to terraform 1.9.0.
Update to used cross object referencing.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers