feat : Add support to specify endpoint of service credentials#851
Open
Khuzaima05 wants to merge 3 commits intomainfrom
Open
feat : Add support to specify endpoint of service credentials#851Khuzaima05 wants to merge 3 commits intomainfrom
Khuzaima05 wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
Member
Author
Member
Author
|
/run pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds endpoint selection support for Redis service credentials created with ibm_resource_key, aligned with the Event Streams implementation pattern.
Reference: Terraform IBM Provider – resource_key parameters
Changes:
issue : https://github.ibm.com/GoldenEye/issues/issues/16679#issue-56112021
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Breaking changes
service_credential_namesinput format frommap(string)tolist(object(...)).New features
ibm_resource_key.endpointtopublicorprivate.Validation updates
public,private).service_endpointsandservice_credential_names[*].endpoint:service_endpoints = "private"disallows credential endpointpublicservice_endpoints = "public"disallows credential endpointprivateMigration guide
Old format:
New format
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers