generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Create Fully Configurable and Security Enforced DA #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e681f74
feat: fully configurable da
kierramarie 721c822
feat: security enforced da
kierramarie 209aafc
fix: update cra-config
kierramarie 887c750
fix: update vars for fully config schematics test
kierramarie 213d67b
Merge branch 'main' into ks-da
kierramarie ae12f6d
refactor: sync with redis
kierramarie 959e735
fix: enhanced ux
kierramarie 9555205
fix: missed things when syncing with redis
kierramarie 8d0cc00
Merge branch 'main' into ks-da
kierramarie 45012ba
fix: a few more changes
kierramarie 2a3cbe6
Merge branch 'ks-da' of github.com:terraform-ibm-modules/terraform-ib…
kierramarie 28fb5ef
fix: diagram
kierramarie c8d694a
test: fix kms vars in test
kierramarie 427f49f
SKIP UPGRADE TEST
kierramarie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
| # More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml | ||
| version: "v1" | ||
| CRA_TARGETS: | ||
| - CRA_TARGET: "solutions/standard" | ||
| - CRA_TARGET: "solutions/fully-configurable" | ||
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" | ||
| PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile). | ||
| CRA_ENVIRONMENT_VARIABLES: | ||
| TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::" | ||
| TF_VAR_existing_kms_key_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9:key:1368d2eb-3ed0-4a8b-b09c-2155895f01ea" | ||
| TF_VAR_use_existing_resource_group: true | ||
| TF_VAR_resource_group_name: "geretain-test-redis" | ||
| TF_VAR_existing_resource_group_name: "geretain-test-rabbitmq" | ||
| TF_VAR_kms_encryption_enabled: true | ||
| TF_VAR_provider_visibility: "public" | ||
| TF_VAR_prefix: "test" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.