Skip to content

Create Fully Configurable and Security Enforced DA #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 30, 2025
Merged

Create Fully Configurable and Security Enforced DA #399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e681f74
feat: fully configurable da
kierramarie Jun 3, 2025
721c822
feat: security enforced da
kierramarie Jun 6, 2025
209aafc
fix: update cra-config
kierramarie Jun 6, 2025
887c750
fix: update vars for fully config schematics test
kierramarie Jun 6, 2025
213d67b
Merge branch 'main' into ks-da
kierramarie Jun 26, 2025
ae12f6d
refactor: sync with redis
kierramarie Jun 27, 2025
959e735
fix: enhanced ux
kierramarie Jun 27, 2025
9555205
fix: missed things when syncing with redis
kierramarie Jun 30, 2025
8d0cc00
Merge branch 'main' into ks-da
kierramarie Jun 30, 2025
45012ba
fix: a few more changes
kierramarie Jun 30, 2025
2a3cbe6
Merge branch 'ks-da' of github.com:terraform-ibm-modules/terraform-ib…
kierramarie Jun 30, 2025
28fb5ef
fix: diagram
kierramarie Jun 30, 2025
c8d694a
test: fix kms vars in test
kierramarie Jun 30, 2025
427f49f
SKIP UPGRADE TEST
kierramarie Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ibm_catalog.json
View file
Open in desktop
Copy link
Contributor

@akocbek akocbek Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes added to fully-configurable apply to security-enforced as well

Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
{
"title": "KMS encryption",
"description": "Provides [KMS encryption](https://cloud.ibm.com/docs/messages-for-rabbitmq?topic=messages-for-rabbitmq-key-protect&interface=ui) for the data that you store in the database, enhancing data security."

},
{
"title": "Autoscaling",
Expand Down Expand Up @@ -64,7 +63,7 @@
"iam_permissions": [
{
"role_crns": [
"crn:v1:bluemix:public:iam::::role:Viewer"
"crn:v1:bluemix:public:iam::::role:Viewer"
],
"service_name": "Resource group only",
"notes": "Viewer access is required in the resource group you want to provision in."
Expand Down Expand Up @@ -133,7 +132,6 @@
{
"key": "existing_resource_group_name",
"display_name": "resource_group",
"required": true,
"custom_config": {
"type": "resource_group",
"grouping": "deployment",
Expand Down Expand Up @@ -372,10 +370,10 @@
"key": "skip_rabbitmq_kms_auth_policy"
},
{
Copy link
Contributor

@akocbek akocbek Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "key": "cbr_rules" at the end, sync with redis

Copy link
Member Author

@kierramarie kierramarie Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis doesn't use cbr_rules. should I remove it from this as well?

"key": "cbr_rules"
"key": "existing_rabbitmq_instance_crn"
},
{
"key": "existing_rabbitmq_instance_crn"
"key": "cbr_rules"
}
]
Copy link
Contributor

@akocbek akocbek Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move "key": "cbr_rules" after existing_rabbitmq_instance_crn. following the rule that inputs that are not in redis, should be placed at the end

image

Copy link
Contributor

@akocbek akocbek Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check security-enforced as well

},
Expand All @@ -397,7 +395,7 @@
"iam_permissions": [
{
"role_crns": [
"crn:v1:bluemix:public:iam::::role:Viewer"
"crn:v1:bluemix:public:iam::::role:Viewer"
],
"service_name": "Resource group only",
"notes": "Viewer access is required in the resource group you want to provision in."
Expand Down Expand Up @@ -447,7 +445,7 @@
},
{
"key": "existing_resource_group_name",
Copy link
Contributor

@akocbek akocbek Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with redis

"required": true,
"display_name": "resource_group",
"custom_config": {
"type": "resource_group",
"grouping": "deployment",
Expand Down Expand Up @@ -636,10 +634,10 @@
"key": "skip_rabbitmq_kms_auth_policy"
},
{
"key": "cbr_rules"
"key": "existing_rabbitmq_instance_crn"
},
{
"key": "existing_rabbitmq_instance_crn"
"key": "cbr_rules"
}
]
}
Copy link
Contributor

@akocbek akocbek Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diagrams not the same in light and dark mode (do we need that extra arrow?). Also name the key, probably would be rabbitmq-key?

image image

Copy link
Member Author

@kierramarie kierramarie Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that arrow was an accident. I've removed it.

Expand Down
Loading