Skip to content

Conversation

@smguilia
Copy link

@smguilia smguilia commented Jun 12, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor

shemau commented Jun 17, 2025

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are additional variables.tf files in the solutions/security-enforced and solutions/fully-configurable folders. These two other files should be close to identical to each other. Security-enhanced has less variables, since it is more opinionated.

@shemau
Copy link
Contributor

shemau commented Jun 18, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smguilia - thanks for the PR. It seems you reviewed the module input variables, as opposed to the DA ones. The DA inuts are in:

  • solutions/fully-configurable/variables.tf
  • solutions/security-enforced/variables.tf

@smguilia
Copy link
Author

Let me add those to this PR before it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants