-
Notifications
You must be signed in to change notification settings - Fork 5
Update ibm_catalog.json #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are additional variables.tf files in the solutions/security-enforced and solutions/fully-configurable folders. These two other files should be close to identical to each other. Security-enhanced has less variables, since it is more opinionated.
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smguilia - thanks for the PR. It seems you reviewed the module input variables, as opposed to the DA ones. The DA inuts are in:
- solutions/fully-configurable/variables.tf
- solutions/security-enforced/variables.tf
|
Let me add those to this PR before it gets merged. |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers