Skip to content

fix: remove the deprecated force delete flag #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: remove the deprecated force delete flag #632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e259376
fix: remove the deprecated force delete flag
MatthewLemmond Oct 4, 2024
d19987d
refactor: bump required version
MatthewLemmond Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ No modules.
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_endpoint_type"></a> [endpoint\_type](#input\_endpoint\_type) | The type of endpoint to be used for creating keys. Accepts 'public' or 'private' | `string` | `"public"` | no |
| <a name="input_force_delete"></a> [force\_delete](#input\_force\_delete) | Set to `true` if you wish to force delete the kms key rings, else `false`. | `bool` | `false` | no |
| <a name="input_instance_id"></a> [instance\_id](#input\_instance\_id) | The KMS instance GUID | `string` | n/a | yes |
| <a name="input_key_ring_id"></a> [key\_ring\_id](#input\_key\_ring\_id) | The ID that identifies the Key Ring. Each ID is unique within the given KMS instance but is not reserved across the KMS service | `string` | n/a | yes |

Expand Down
7 changes: 3 additions & 4 deletions examples/basic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
##############################################################################

module "kms_key_ring" {
source = "../.."
instance_id = var.existing_kms_instance_guid
key_ring_id = "${var.prefix}-key-ring"
force_delete = true # Setting it to true for testing purpose
source = "../.."
instance_id = var.existing_kms_instance_guid
key_ring_id = "${var.prefix}-key-ring"
}
1 change: 0 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ resource "ibm_kms_key_rings" "key_ring" {
endpoint_type = var.endpoint_type
instance_id = var.instance_id
key_ring_id = var.key_ring_id
force_delete = var.force_delete
}
6 changes: 0 additions & 6 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ variable "instance_id" {
description = "The KMS instance GUID"
}

variable "force_delete" {
type = bool
description = "Set to `true` if you wish to force delete the kms key rings, else `false`."
default = false
}

variable "key_ring_id" {
type = string
description = "The ID that identifies the Key Ring. Each ID is unique within the given KMS instance but is not reserved across the KMS service"
Expand Down