Skip to content

refactor: Split Observability DA into 3 DA's #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Sep 2, 2025
Merged

refactor: Split Observability DA into 3 DA's #1040

merged 58 commits into from
Sep 2, 2025

Conversation

@vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Aug 15, 2025

Description

Split Observability DA into 3 DA's

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17 vkuma17 marked this pull request as draft August 15, 2025 15:32
@vkuma17 vkuma17 marked this pull request as ready for review August 21, 2025 12:21
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 21, 2025

There are some issues in testwrapper with permutation tests in addons testing. So for now we are skipping the permutation test using t.skip().. it can be removed later once issue is fixed.

rajatagarwal-ibm
rajatagarwal-ibm requested changes Aug 21, 2025
View reviewed changes
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update all the "observability" references from the ibm_catalog.json file.

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 21, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 21, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

1 similar comment
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

There are some issues in testwrapper with permutation tests in addons testing. So for now we are skipping the permutation test using t.skip().. it can be removed later once issue is fixed.

Issues are fixed in latest version of wrapper so we are not skipping anything.

rajatagarwal-ibm
rajatagarwal-ibm requested changes Aug 22, 2025
View reviewed changes
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

5 similar comments
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 22, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 23, 2025

/run pipeline

ocofaigh
ocofaigh previously approved these changes Sep 1, 2025
View reviewed changes
@ocofaigh ocofaigh mentioned this pull request Sep 1, 2025
Merged
6 tasks
@daniel-butler-irl
Copy link
Contributor

daniel-butler-irl commented Sep 1, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Sep 1, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Sep 1, 2025

/run pipeline

1 similar comment
@vkuma17
Copy link
Contributor Author

vkuma17 commented Sep 1, 2025

/run pipeline

maheshwarishikha
maheshwarishikha reviewed Sep 2, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Sep 2, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Sep 2, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Sep 2, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Sep 2, 2025
View reviewed changes
@maheshwarishikha
Copy link
Member

maheshwarishikha commented Sep 2, 2025

/run pipeline

1 similar comment
@vkuma17
Copy link
Contributor Author

vkuma17 commented Sep 2, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 8db31c5 into main Sep 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the split-obs branch September 2, 2025 09:07
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Sep 2, 2025

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-butler-irl daniel-butler-irl daniel-butler-irl left review comments

@maheshwarishikha maheshwarishikha maheshwarishikha approved these changes

@ocofaigh ocofaigh ocofaigh left review comments

@rajatagarwal-ibm rajatagarwal-ibm rajatagarwal-ibm left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vkuma17 @rajatagarwal-ibm @ocofaigh @daniel-butler-irl @maheshwarishikha @terraform-ibm-modules-ops