Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented May 20, 2025

Description

Migration for VPC

issue: https://github.ibm.com/GoldenEye/issues/issues/13500

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member

/run pipeline

@maheshwarishikha
Copy link
Member

/run pipeline

@maheshwarishikha
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member Author

The upgrade test is failing because additional subnets are being added to the default configuration, which results in an update to the ibm_is_network_acl.network_acl resource.

Screenshot 2025-06-11 at 10 49 44 AM

So skipping the upgrade test.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Jun 11, 2025

Deployed Successfully:
Screenshot 2025-06-11 at 1 52 10 PM

Undeployed Successfully:
Screenshot 2025-06-11 at 2 00 20 PM

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

Successfully deployed without account infra:

Screenshot 2025-06-11 at 4 24 20 PM

@maheshwarishikha maheshwarishikha dismissed stale reviews from rajatagarwal-ibm and ocofaigh June 11, 2025 11:54

feedback addressed

@maheshwarishikha maheshwarishikha merged commit d80134a into main Jun 11, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the issue_13500 branch June 11, 2025 12:41
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants