Skip to content

Conversation

@rajatagarwal-ibm
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm commented Sep 8, 2025

Description

Addresses this issue: #1044

fixes #1044

added local and ip_version.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

@maheshwarishikha @vburckhardt: Is there a reason why the https://github.com/terraform-ibm-modules/terraform-ibm-security-group/tree/main module is not consumed for managing security group resources? The same changes need to be maintain there too.

@vburckhardt
Copy link
Member

Add an example that use the new field so that this field is picked up in our automated test suite

@rajatagarwal-ibm
Copy link
Member Author

@vburckhardt I had the same thought, but then the same logic is used in security-group module. Also, tests wouldn't catch that as they are optional field.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

@toddgiguere ran custom SG test locally, and it passed.
image

@toddgiguere toddgiguere merged commit f67ea06 into main Sep 8, 2025
2 checks passed
@toddgiguere toddgiguere deleted the sg-local branch September 8, 2025 15:58
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security_group_rule resource in module doesn't support 'local' arg as in provider doc

5 participants