Skip to content

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented Oct 23, 2025

Description

remove enable_vpc_flow_logs mapping from kms dependency

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait hang on - I thought it was Cloud Logs DA where COS needs to made required? VPC DA will only use COS for flow logs. And if COS is disabled, flow logs should be disabled. So there should be no need to make it required in this DA?

@whoffler whoffler changed the title require COS dependency remove enable_vpc_flow_logs mapping from kms dependency Oct 24, 2025
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

whoffler commented Oct 24, 2025

✔ Extracting only cost-related params from terraform
 2025/10/24 09:03:27 Schematics Cost Estimation | 
 2025/10/24 09:03:27 Schematics Cost Estimation | Error: Invalid API response: 403 Forbidden
 2025/10/24 09:03:27 Schematics Cost Estimation | We have been notified of this issue.
 2025/10/24 09:03:27 Schematics Cost Estimation | Configured IAM URL https://iam.cloud.ibm.com/
 2025/10/24 09:03:28 Schematics Cost Estimation | 
 2025/10/24 09:03:28 Schematics Cost Estimation | version: 0.1-20250919-115801-207
 2025/10/24 09:03:33 Done with the workspace action
...
[TestVpcAddonDefaultConfiguration]   Schematics job logs for member: deploy-arch-ibm-cloud-monitoring-wjmkx4, Schematics Workspace CRN: crn:v1:bluemix:public:schematics:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:1ee5da6e-73a1-41c4-86c6-5defef85366a:workspace:eu-de.workspace.projects-service.ed636e6f, Schematics Validate Job ID: 0390aeb9a5016dc4e525aa4a8dcb0974
Schematics workspace URL: https://cloud.ibm.com/schematics/workspaces/eu-de.workspace.projects-service.ed636e6f/jobs?region=eu
Schematics Job URL: https://cloud.ibm.com/schematics/workspaces/eu-de.workspace.projects-service.ed636e6f/log/0390aeb9a5016dc4e525aa4a8dcb0974
	(deploy-arch-ibm-cloud-monitoring-wjmkx4) Validation result: failed

@whoffler
Copy link
Contributor Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants