-
Notifications
You must be signed in to change notification settings - Fork 17
remove enable_vpc_flow_logs mapping from kms dependency #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait hang on - I thought it was Cloud Logs DA where COS needs to made required? VPC DA will only use COS for flow logs. And if COS is disabled, flow logs should be disabled. So there should be no need to make it required in this DA?
|
/run pipeline |
|
/run pipeline |
|
|
/run pipeline |
Description
remove enable_vpc_flow_logs mapping from kms dependency
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers