Skip to content

Conversation

@vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Mar 27, 2025

Description

Scope auth policy for flow logs to exact cos bucket
Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Scope auth policy VPC to COS to exact cos bucket for flow logs collector

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

/run pipeline

@ocofaigh
Copy link
Contributor

@Vipin654 Please don't skip the upgrade test in the first commit - we need to see the result of it to:

  • make sure there isn't any other non expected breaking changes
  • ensure the new auth policy is created before destroyed
  • use the result as part of the release notes

I need to see proof of upgrade result before merging this. Maybe run it locally and paste result?

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

Screenshot 2025-03-27 at 6 45 44 PM @ocofaigh I have attached a screenshot of local run

@vkuma17
Copy link
Contributor Author

vkuma17 commented Mar 27, 2025

attached one more screenshot which tells the order
Screenshot 2025-03-27 at 6 50 22 PM

@maheshwarishikha
Copy link
Member

@ocofaigh
Upgrade test shows it creates policy before destroy. So looks fine.
sh we merge?

@ocofaigh ocofaigh merged commit 032c772 into main Mar 28, 2025
2 checks passed
@ocofaigh ocofaigh deleted the s2s_exact_cos branch March 28, 2025 08:28
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants