-
Notifications
You must be signed in to change notification settings - Fork 36
fix: updated roks quickstart ref arch #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
maheshwarishikha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object Storage Storageis a wrong name- Subnet boxes (10.10../24 : Subnet) - seems to be small i.e. text inside this looks so compact. Please make boxes lil bigger then it will look better.
One open question - Not sure if Zone, subnet boxes was colored intentionally and we want to continue using that.
|
Also, please mention about the changes done in the issue clearly. Specially what was the change required as per SF guidelines. It will help us to understand. |
Updated the PR as per comment. Examples mentioned in ibm-cloud-stensils: |
|
These are the changes made: ref
|
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
You're getting only one cluster however in quick start. With 2 nodes. New diagram is showing 2 clusters. |
|
Also, one of the sticking points is that there is no compute resource in the management VPC. We should explicitly indicate that the empty subnet is intentionally left vacant, allowing the user to deploy their preferred compute—whether VSI or OpenShift—for management purposes, in alignment with the FsCloud topology. Possibly put "Reserved for user-managed compute (per FsCloud topology)" On the HPCS - do quick start support it? If not, remove HPCS from diagram. Could we also loop back with Jose Monge to validate the new version. He's driving the stencil initiative and has been historically involved with our group. |
Reviewed the updated diagram with Jose Monge . He confirmed the diagram looks good and suggested a few minor changes, which I’ve incorporated. |
|
/run pipeline |
|
I believe it’s acceptable to proceed. Additionally, we should update the diagrams in the other variations (particularly the standard version) to align with the new version of the quick start. Most users prefer to quickly compare variations using the diagrams - could we make sure that this is tracked and prioritized. |
|
/run pipeline |
|
🎉 This PR is included in version 8.4.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |


Description
Changes made: ref
issue: https://github.ibm.com/GoldenEye/issues/issues/15100
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers