Skip to content

Conversation

@aatreyee257
Copy link
Contributor

@aatreyee257 aatreyee257 commented Sep 10, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/15555

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee257 aatreyee257 self-assigned this Sep 10, 2025
Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Few minor comments:

  • There is some spacing issue in between of boxes.
image
  • Space issue in the label Cloud Service Resource Group

  • Please bring labels left aligned i.e. near to icon. Especially for the subnets and security group. Check for all.

image

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other modified diagrams -
The subnets name uses the following convention - <ip>: Subnet
In this diagram it is - <ip> : Subnet

Please make it consistent.

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aatreyee257
Copy link
Contributor Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit a122acf into main Sep 11, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the i-15555 branch September 11, 2025 15:33
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.5.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants