fix: missing os in override json #908
Conversation
|
/run pipeline |
|
/run pipeline |
patterns/roks/variables.tf
Outdated
| type = string | ||
| description = "The operating system of the workers in the default worker pool. If no value is specified, the current default version OS will be used. See https://cloud.ibm.com/docs/openshift?topic=openshift-openshift_versions#openshift_versions_available ." | ||
| default = "REDHAT_8_64" | ||
| description = "The operating system of the workers in the default worker pool. See https://cloud.ibm.com/docs/openshift?topic=openshift-openshift_versions#openshift_versions_available ." |
There was a problem hiding this comment.
Isn't the same change needed in roks/module/variables.tf ?
There was a problem hiding this comment.
Thats the tricky part when we directly call the module folder we need to pass a value for the var.operating system even if have a value for it mentioned in the override.json. For example, in quickstart
another option is to remove the var.operating system get the value from json and hardcode "REDHAT_8_64" in the config.tf
@toddgiguere , any idea on a different approach ?
There was a problem hiding this comment.
I think you should leave the default in place for var.operating_system, since there is a good default for the default worker pool (which is REDHAT_8_64).
I think the idea of not having a default value was more for the additional worker pools, which this variable is not used for.
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
catalogValidationValues.json.template will need to be updated too
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers