-
Notifications
You must be signed in to change notification settings - Fork 2
Rename logs_agent_additional_log_source_paths to logs_agent_system_logs
#101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not see anything wrong with this change. It is changing an input, which is UI visible in the DA; so I flagged this as breaking change.
As such some words should be added to the release notes to clearly explain what changed in both the module (variable name, input on module) and the DA (variable name and the potential to have to copy the old value to the new input while migrating/upgrading the DA.
|
/run pipeline |
|
Error: |
|
/run pipeline |
|
Error: |
|
@kierramarie I don't see how this is a major version release? Its not going to destroy anything - I have changed it to a minor version. |
|
/run pipeline |
I have reached out to IKS team |
|
/run pipeline |
|
Same errors. |
|
@kierramarie The issue seems to be related to eu-gb - perhaps temporarily update tests so they don't use this region? |
|
/run pipeline |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Rename
logs_agent_additional_log_source_pathstologs_agent_system_logs. Also adjusted name in main module to have new namesystemLogs.Git Issue: #100
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers