Skip to content

Conversation

@kierramarie
Copy link
Member

@kierramarie kierramarie commented Jul 2, 2025

Description

Rename logs_agent_additional_log_source_paths to logs_agent_system_logs. Also adjusted name in main module to have new name systemLogs.

Git Issue: #100

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

shemau
shemau previously approved these changes Jul 11, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not see anything wrong with this change. It is changing an input, which is UI visible in the DA; so I flagged this as breaking change.

As such some words should be added to the release notes to clearly explain what changed in both the module (variable name, input on module) and the DA (variable name and the potential to have to copy the old value to the new input while migrating/upgrading the DA.

@shemau
Copy link
Contributor

shemau commented Jul 11, 2025

/run pipeline

@kierramarie
Copy link
Member Author

Error:

│ Error: timeout while waiting for state to become 'Ready' (last state: 'Deploy in progress', timeout: 1h30m0s)
│ 
│   with ibm_container_vpc_cluster.cluster[0],
│   on main.tf line 60, in resource "ibm_container_vpc_cluster" "cluster":
│   60: resource "ibm_container_vpc_cluster" "cluster" {
│ 
│ ---
│ id: terraform-40a3a1fe
│ summary: 'timeout while waiting for state to become ''Ready'' (last state:
│ ''Deploy
│   in progress'', timeout: 1h30m0s)'
│ severity: error
│ resource: ibm_container_vpc_cluster
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.79.0
│ ---
│ 
╵}
=== NAME  TestRunAgentVpcKubernetes

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

Error:

TestFullyConfigurableUpgradeSolution 2025-07-21T17:08:32Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Request failed with status code: 500, ServerErrorResponse: {"incidentID":"f7591b25-8c8b-a071-bf0b-c500a27c5cd0","code":"Ed196","description":"Could not connect to a backend service. Try again later.","type":""}
│ 
│   with module.ocp_base.ibm_container_vpc_cluster.cluster[0],
│   on .terraform/modules/ocp_base/main.tf line 135, in resource "ibm_container_vpc_cluster" "cluster":
│  135: resource "ibm_container_vpc_cluster" "cluster" {
│ 
│ ---
│ id: terraform-40a3a1fe
│ summary: 'Request failed with status code: 500, ServerErrorResponse:
│ {"incidentID":"f7591b25-8c8b-a071-bf0b-c500a27c5cd0","code":"Ed196","description":"Could
│   not connect to a backend service. Try again later.","type":""}'
│ severity: error
│ resource: ibm_container_vpc_cluster
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.80.3
│ ---
│ 
╵}

@ocofaigh
Copy link
Contributor

@kierramarie I don't see how this is a major version release? Its not going to destroy anything - I have changed it to a minor version.

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Jul 23, 2025

│ Error: Request failed with status code: 500, ServerErrorResponse: {"incidentID":"bd623f38-4dbc-a4c0-9093-ed8057203b92","code":"Ed196","description":"Could not connect to a backend service. Try again later.","type":""}
│ 
│   with module.ocp_base.ibm_container_vpc_cluster.cluster[0],
│   on .terraform/modules/ocp_base/main.tf line 128, in resource "ibm_container_vpc_cluster" "cluster":
│  128: resource "ibm_container_vpc_cluster" "cluster" {
│ 
│ ---
│ id: terraform-40a3a1fe
│ summary: 'Request failed with status code: 500, ServerErrorResponse:
│ {"incidentID":"bd623f38-4dbc-a4c0-9093-ed8057203b92","code":"Ed196","description":"Could
│   not connect to a backend service. Try again later.","type":""}'
│ severity: error
│ resource: ibm_container_vpc_cluster
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.80.3
│ ---
│ 
╵}

I have reached out to IKS team

@ocofaigh
Copy link
Contributor

/run pipeline

@kierramarie
Copy link
Member Author

Same errors.

@ocofaigh
Copy link
Contributor

@kierramarie The issue seems to be related to eu-gb - perhaps temporarily update tests so they don't use this region?

@kierramarie
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit b4582d3 into main Jul 24, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ks-logs-source-var branch July 24, 2025 17:13
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants