Skip to content

fix: pre-commit issues #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aashiq-J merged 1 commit into from
Dec 9, 2025
Merged

fix: pre-commit issues #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 8 files
+11 −1 commonRenovateConfig.json
+1 −1 da-assets/da-dependency-updater/requirements.txt
+1 −1 module-assets/.pre-commit-config.yaml
+3 −0 module-assets/ci/.typos.toml
+3 −3 module-assets/ci/install-deps.sh
+92 −13 module-assets/ci/validateIbmCatalogJson.py
+1 −1 scripts/iks-api-key-reset/reset_iks_api_key.sh
+1 −1 tests/go.mod
22 changes: 19 additions & 3 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"index": 1,
"install_type": "fullstack",
"working_directory": "solutions/fully-configurable",
"short_description": "Configurable deployment of Logs Agent on a Kubernetes or OpenShift cluster with customizable settings for filters, metadata, and tolerations.",
Copy link
Contributor

@ocofaigh ocofaigh Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jor2 Can this be changed to be consistent with what we have in other DAs. Fully configurable variations should say:
"Ideal for users who want flexibility with a reliable starting point."

"iam_permissions": [
{
"service_name": "containers-kubernetes",
Expand Down Expand Up @@ -324,7 +325,12 @@
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment"
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": [
"hcl"
]
}
}
},
{
Expand Down Expand Up @@ -412,7 +418,12 @@
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment"
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": [
"hcl"
]
}
}
},
{
Expand All @@ -423,7 +434,12 @@
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment"
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": [
"hcl"
]
}
}
},
{
Expand Down