Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented May 8, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this May 8, 2025
@jor2 jor2 requested review from Aashiq-J and shemau as code owners May 8, 2025 12:20
@jor2
Copy link
Member Author

jor2 commented May 8, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram needs a white background so it shows better when in dark mode. Currently it shows like this:
image

ocofaigh
ocofaigh previously approved these changes May 8, 2025
@ocofaigh
Copy link
Contributor

ocofaigh commented May 8, 2025

/run pipeline

ocofaigh
ocofaigh previously approved these changes May 8, 2025
@jor2
Copy link
Member Author

jor2 commented May 8, 2025

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented May 8, 2025

[ERROR] Error waiting for create resource instance (crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:f04a35ca-7e1f-4a18-8a70-3bdede100a12::) to be succeeded: [ERROR] The resource instance 'crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:f04a35ca-7e1f-4a18-8a70-3bdede100a12::' create failed during async operation. error: <nil>

Unrelated to changes in this PR so re-running. Ive reported to ICL team

@ocofaigh
Copy link
Contributor

ocofaigh commented May 8, 2025

/run pipeline

1 similar comment
@ocofaigh
Copy link
Contributor

ocofaigh commented May 9, 2025

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented May 9, 2025

More ICL provisioning issues :(

[ERROR] Error waiting for create resource instance (crn:v1:bluemix:public:logs:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:97ac6338-c194-4bb4-8721-deee83827d9e::) to be succeeded: [ERROR] The resource instance 'crn:v1:bluemix:public:logs:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:97ac6338-c194-4bb4-8721-deee83827d9e::' create failed during async operation. error: <nil>

Still working with ICL team - going to retry...

@ocofaigh
Copy link
Contributor

ocofaigh commented May 9, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jor2 You need to add module.logs_agent.helm_release.logs_agent to the ignore update list in the tests - this will always update - its expected

        	Messages:   	Resource(s) identified to be updated 
        	            	Name: logs_agent
        	            	Address: module.logs_agent.helm_release.logs_agent
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"metadata":"SECURE_VALUE_HIDDEN_HASH:-2b96507925d6018881cfa57b82dbd0c1acdbf1c4c8eff0d80f35c7fa","values":"SECURE_VALUE_HIDDEN_HASH:-4ee8601c9f85c77b3fa0e9df932db8e84a70a3f26e2c9904198da971"}
        	            	  After: 
        	            		{}

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit 94753a8 into main May 11, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fix-da branch May 11, 2025 13:30
@jor2 jor2 mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants