-
Notifications
You must be signed in to change notification settings - Fork 2
fix: small issues with DA #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/run pipeline |
|
/run pipeline |
Unrelated to changes in this PR so re-running. Ive reported to ICL team |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
More ICL provisioning issues :( Still working with ICL team - going to retry... |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jor2 You need to add module.logs_agent.helm_release.logs_agent to the ignore update list in the tests - this will always update - its expected
Messages: Resource(s) identified to be updated
Name: logs_agent
Address: module.logs_agent.helm_release.logs_agent
Actions: [update]
DIFF:
Before:
{"metadata":"SECURE_VALUE_HIDDEN_HASH:-2b96507925d6018881cfa57b82dbd0c1acdbf1c4c8eff0d80f35c7fa","values":"SECURE_VALUE_HIDDEN_HASH:-4ee8601c9f85c77b3fa0e9df932db8e84a70a3f26e2c9904198da971"}
After:
{}
|
/run pipeline |

Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers