generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: initial module + DA #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
711a8b6
feat: initial module + DA
cb9494f
Merge branch 'main' into agent-da
jor2 2ecdbb7
feat: update code
b29584c
feat: update code
c808266
feat: update code
13c8f99
fix: catalog.json SKIP UPGRADE TESTS
df3c030
fix: update outputs
1b9cb91
fix: add dir
5f908cd
fix: outbound traffic
8198c0b
fix: outbound traffic
a969063
fix: outbound traffic
9e939dc
fix: address feedback
eaae3d2
Merge branch 'main' into agent-da
jor2 fc9ce23
fix: address feedback
c9b83a2
fix: address feedback
5b9d124
fix: address feedback
4aa3fbc
Merge branch 'main' into agent-da
jor2 e3ada1e
fix: address feedback
e2f7c9c
fix: address feedback
2c211b2
Merge branch 'main' into agent-da
jor2 fe841bd
fix: address feedback
d80d603
fix: address feedback
ce0f7e1
Merge branch 'main' into agent-da
jor2 acb982e
fix: address feedback
b7b304b
fix: address feedback
c341bb0
fix: address feedback
137a2ec
fix: address feedback
67c941a
Merge branch 'main' into agent-da
jor2 b22a686
fix: address feedback
86e52a1
fix: address feedback
b8725c5
fix: address feedback
2fbe1fd
fix: address feedback
dfbaaee
fix: address feedback
4924c43
Merge branch 'main' into agent-da
jor2 17ec977
fix: address feedback
ede2e70
fix: address feedback
01ebab4
tests: add plan tests
4dd7a9f
fix: address feedback
78eb2cb
fix: address feedback
cb8b621
fix: address feedback
715df11
fix: address feedback
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule common-dev-assets
updated
3 files
| +4 −2 | module-assets/.pre-commit-config.yaml | |
| +2 −2 | module-assets/ci/install-deps.sh | |
| +1 −1 | stack-assets/.pre-commit-config.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -159,3 +159,17 @@ variable "chart_version" { | |||||
| default = "1.79.0" # Replace with the desired version | ||||||
|
||||||
| default = "1.79.0" # Replace with the desired version | |
| default = "1.79.0" # registryUrl: charts.sysdig.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the renovate.json file with the following contents:
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>terraform-ibm-modules/common-dev-assets:commonRenovateConfig"],
"customManagers": [
{
"customType": "regex",
"description": "Update docker image digest to latest in variables.tf",
"fileMatch": ["variables.tf$"],
"datasourceTemplate": "docker",
"matchStrings": [
"default\\s*=\\s*\"(?<currentValue>[\\w.-]+)@(?<currentDigest>sha256:[a-f0-9]+)\"\\s*# datasource: (?<depName>[^\\s]+)"
]
},
{
"customType": "regex",
"description": "Update sysdig-deploy helm chart version to latest in variables.tf",
"fileMatch": ["variables.tf$"],
"matchStrings": ["default\\s*=\\s*\"(?<currentValue>.*?)\"\\s*# registryUrl: charts.sysdig.com\\n"],
"depNameTemplate": "sysdig-deploy",
"datasourceTemplate": "helm",
"registryUrlTemplate": "https://charts.sysdig.com"
}
],
"packageRules": [
{
"description": "Bundle image + helm chart updates into the same PR",
"matchPackageNames": ["icr.io/ext/sysdig/agent", "sysdig-deploy"],
"groupName": "Charts and Images",
"commitMessageExtra": "to latest",
"group": true
}
]
}
jor2 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
jor2 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.