-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: Update prefix logic in DA #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
iamar7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking for null & empty strings everywhere like this -> (var.prefix != null && var.prefix != "").
Could you please use the same method as in this PR?
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
iamar7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/run pipeline |
|
🎉 This PR is included in version 2.8.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Updated the code logic of prefix variable such that it allows prefix to be "" (empty string) for advanced users. Also, added default value(dev) for prefix and marked as required in catalog manifest.
#11959
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Adds the default value for prefix variable and mark as required in catalog manifest. Also allows prefix to be "" (empty string ).
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers