-
Notifications
You must be signed in to change notification settings - Fork 8
feat: code change for sap-s4hana-bw4hana dir #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SKIP UPGRADE TEST: breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes.
Also update the catalog.json file
Co-authored-by: Suraj Bharadwaj <[email protected]>
Co-authored-by: Suraj Bharadwaj <[email protected]>
Co-authored-by: Suraj Bharadwaj <[email protected]>
Co-authored-by: Suraj Bharadwaj <[email protected]>
Co-authored-by: Suraj Bharadwaj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more
SKIP UPGRADE TEST: breaking change
SKIP UPGRADE TEST: breaking change
|
@tripan27 please include the 10.2.0 version and the new var enable_montoring_host for the module and push to both solution. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes required. Please see comments above
SKIP UPGRADE TEST: breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default must be removed.
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
… on reapply, enable mad04 and dal14 DC (#887)
|
/run pipeline |
|
/run pipeline |
Description
Single click HANA deployment, eliminate prerequisite ids
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers