Skip to content

Conversation

@tripan27
Copy link
Collaborator

@tripan27 tripan27 commented Oct 16, 2025

Description

Single click HANA deployment, eliminate prerequisite ids

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

SKIP UPGRADE TEST: breaking change
Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

Also update the catalog.json file

Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more

SKIP UPGRADE TEST: breaking change
SKIP UPGRADE TEST: breaking change
@surajsbharadwaj
Copy link
Contributor

@tripan27 please include the 10.2.0 version and the new var enable_montoring_host for the module and push to both solution. Thank you

Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More changes required. Please see comments above

SKIP UPGRADE TEST: breaking change
Copy link
Contributor

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default must be removed.

@surajsbharadwaj surajsbharadwaj changed the title chore: code change for sap-s4hana-bw4hana dir feat: code change for sap-s4hana-bw4hana dir Oct 24, 2025
@surajsbharadwaj
Copy link
Contributor

/run pipeline

2 similar comments
@surajsbharadwaj
Copy link
Contributor

/run pipeline

@tripan27
Copy link
Collaborator Author

/run pipeline

@surajsbharadwaj
Copy link
Contributor

/run pipeline

@surajsbharadwaj
Copy link
Contributor

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants