Skip to content
This repository was archived by the owner on Mar 19, 2025. It is now read-only.

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 28, 2024

Description

see details in terraform-ibm-modules/terraform-ibm-scc#201

The upgrade test was skipped (low risk) as it would of failed with: terraform-ibm-modules/terraform-ibm-scc#201 (comment)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh requested a review from akocbek as a code owner November 28, 2024 10:50
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

Going to wait for new SCC module version terraform-ibm-modules/terraform-ibm-scc#201

@ocofaigh
Copy link
Contributor Author

/run pipeline

1 similar comment
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

The two instances tests passed:
--- PASS: TestRunExistingResourcesInstances
--- PASS: TestInstancesInSchematics

Proceeding with merge

@ocofaigh ocofaigh merged commit 721f983 into main Nov 28, 2024
1 of 2 checks passed
@ocofaigh ocofaigh deleted the default branch November 28, 2024 12:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants