refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

mounicatellabati · 2025-11-19T08:26:17Z

Description

Added clarification to the cloud_monitoring_instance_crn variable description in both the module and DA to state that once the Monitoring Instance CRN is connected to the Security and Compliance Center Workload Protection service, it cannot be modified or updated. for issue https://github.ibm.com/GoldenEye/issues/issues/16321.

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

… lifecycle block

mounicatellabati · 2025-11-20T10:35:58Z

raagamounica@Mac fully-configurable % terraform plan 
module.resource_group.data.ibm_resource_group.default[0]: Reading...
data.ibm_iam_auth_token.auth_token: Reading...
data.ibm_iam_auth_token.auth_token: Read complete after 0s [id=2025-11-20 08:57:59.631884 +0000 UTC]
module.resource_group.data.ibm_resource_group.default[0]: Read complete after 2s [id=07b6d899988a4631841e3bc7d0307dcf]
module.scc_wp.ibm_resource_instance.scc_wp: Refreshing state... [id=crn:v1:bluemix:public:sysdig-secure:us-south:a/abac0df06b644a9cabc6e44f55b3880e:0b325063-081a-4b88-a78a-2df4f77fc788::]
module.scc_wp.data.ibm_iam_auth_token.token[0]: Reading...
module.scc_wp.data.ibm_iam_auth_token.token[0]: Read complete after 0s [id=2025-11-20 08:58:05.238087 +0000 UTC]
module.scc_wp.ibm_resource_key.scc_wp_resource_key: Refreshing state... [id=crn:v1:bluemix:public:sysdig-secure:us-south:a/abac0df06b644a9cabc6e44f55b3880e:0b325063-081a-4b88-a78a-2df4f77fc788:resource-key:4c81c5dc-c0e8-490f-8f6c-ec42ef893a0b]
module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile.profile: Refreshing state... [id=Profile-17ff4015-818c-4c0b-b322-12aa255d3a34]
module.scc_wp.module.account_type_check[0].data.external.account_check: Reading...
module.scc_wp.module.account_type_check[0].data.external.account_check: Read complete after 1s [id=-]
module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile_link.link["scc-wp-vsi-link-0"]: Refreshing state... [id=Profile-17ff4015-818c-4c0b-b322-12aa255d3a34/ClaimRule-52eb390a-9c0f-3623-a911-a92e8c8559e7]
module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile_identity.trust_identity[0]: Refreshing state... [id=Profile-17ff4015-818c-4c0b-b322-12aa255d3a34|crn|crn:v1:bluemix:public:sysdig-secure:us-south:a/abac0df06b644a9cabc6e44f55b3880e:0b325063-081a-4b88-a78a-2df4f77fc788::]
module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile_policy.policy["scc-wp"]: Refreshing state... [id=Profile-17ff4015-818c-4c0b-b322-12aa255d3a34/073c041a-3b79-41e9-83ca-dd8fe31d5e80]
module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile_policy.policy["scc-wp-enterprise"]: Refreshing state... [id=Profile-17ff4015-818c-4c0b-b322-12aa255d3a34/596c168c-266d-494b-a38b-69b370546779]
module.scc_wp.restapi_object.cspm: Refreshing state... [id=crn:v1:bluemix:public:sysdig-secure:us-south:a/abac0df06b644a9cabc6e44f55b3880e:0b325063-081a-4b88-a78a-2df4f77fc788::]
 
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create
 
Terraform will perform the following actions:
 
  # module.scc_wp.restapi_object.cspm will be created
  + resource "restapi_object" "cspm" {
      + api_data                  = (known after apply)
      + api_response              = (known after apply)
      + create_method             = "PATCH"
      + create_response           = (known after apply)
      + data                      = jsonencode(
            {
              + parameters = {
                  + enable_cspm     = true
                  + target_accounts = [
                      + {
                          + account_id         = "abac0df06b644a9cabc6e44f55b3880e"
                          + account_type       = "ACCOUNT"
                          + config_crn         = "crn:v1:bluemix:public:apprapp:us-south:a/abac0df06b644a9cabc6e44f55b3880e:041f0216-37cc-472e-93b8-012f75d5c327::"
                          + trusted_profile_id = "Profile-17ff4015-818c-4c0b-b322-12aa255d3a34"
                        },
                    ]
                }
            }
        )
      + destroy_method            = "PATCH"
      + force_new                 = [
          + "true",
        ]
      + id                        = (known after apply)
      + ignore_all_server_changes = false
      + path                      = "/v2/resource_instances/0b325063-081a-4b88-a78a-2df4f77fc788"
      + update_method             = "PATCH"
    }
 
Plan: 1 to add, 0 to change, 0 to destroy.
╷
│ Warning: Argument is deprecated
│ 
│   with module.scc_wp.module.trusted_profile_scc_wp[0].ibm_iam_trusted_profile_policy.policy["scc-wp"],
│   on .terraform/modules/scc_wp.trusted_profile_scc_wp/main.tf line 46, in resource "ibm_iam_trusted_profile_policy" "policy":
│   46:   profile_id         = ibm_iam_trusted_profile.profile.profile_id
│ 
│ This field is deprecated and will be removed starting with this 1.82.0 release. Please use iam_id field instead.



```checked in terraform.state file it is not changing cloud_monitoring_instance

"parameters": {
              "cloud_monitoring_connected_instance": "crn:v1:bluemix:public:sysdig-monitor:us-south:a/abac0df06b644a9cabc6e44f55b3880e:fc8fbda4-0251-4dd7-a451-22b7f0143798::"
            },

akocbek · 2025-11-20T13:48:39Z

/run pipeline

mounicatellabati · 2025-11-20T14:11:04Z

/run pipeline

mounicatellabati · 2025-11-21T05:38:57Z

/run pipeline

terraform-ibm-modules-ops · 2025-11-21T12:46:19Z

🎉 This PR is included in version 1.16.3 🎉

The release is available on:

GitHub release
v1.16.3

Your semantic-release bot 📦🚀

ocofaigh · 2025-11-21T12:48:18Z

solutions/fully-configurable/variables.tf

  nullable    = true
  default     = null
-  description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create a connection between instances. Both instances must be in the same region. [Learn more](https://www.ibm.com/products/cloud-monitoring)"
+  description = "To collect and analyze metrics and security data on hosts using both Monitoring and Workload Protection, pass the CRN of an existing IBM Cloud Monitoring instance to create the connection. Once the connection is created, the Monitoring instance CRN cannot be changed. Learn more](https://www.ibm.com/products/cloud-monitoring)"


You are missing the opening bracket

Also can we point to a better link - thats too generic. Is there any doc that has info abut this topic (connecting instances)

ocofaigh · 2025-11-21T12:48:33Z

main.tf

-    cloud_monitoring_connected_instance : var.cloud_monitoring_instance_crn
+    cloud_monitoring_connected_instance = var.cloud_monitoring_instance_crn
+  }
+  lifecycle {


always leave a code comment as to why your adding a lifecycle ignore

chore: updating the description for existing test

7aff83e

mounicatellabati requested review from akocbek and jor2 as code owners November 19, 2025 08:26

mounicatellabati and others added 2 commits November 19, 2025 14:40

Merge branch 'main' into update-scc

dc27f43

chore: ignoring parameter cloud_monitoring_connected_instance through…

1ff6514

… lifecycle block

mounicatellabati changed the title ~~chore: updating the description for existing test~~ chore: ignoring parameter cloud_monitoring_connected_instance and updating the description. Nov 20, 2025

akocbek previously approved these changes Nov 20, 2025

View reviewed changes

raagamounica added 2 commits November 20, 2025 19:38

fix: update Readme.md file

9ab14de

fix: update Readme.md file

841a47b

mounicatellabati dismissed akocbek’s stale review via 841a47b November 20, 2025 14:10

Merge branch 'main' into update-scc

261fd85

akocbek approved these changes Nov 21, 2025

View reviewed changes

mounicatellabati changed the title ~~chore: ignoring parameter cloud_monitoring_connected_instance and updating the description.~~ refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. Nov 21, 2025

akocbek merged commit b6df46e into main Nov 21, 2025
2 checks passed

akocbek deleted the update-scc branch November 21, 2025 12:45

terraform-ibm-modules-ops added the released label Nov 21, 2025

ocofaigh reviewed Nov 21, 2025

View reviewed changes

ocofaigh mentioned this pull request Nov 26, 2025

Test scenario when changing the Connected Monitoring instance on SCC-WP #326

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

Uh oh!

mounicatellabati commented Nov 19, 2025 •

edited

Loading

Uh oh!

mounicatellabati commented Nov 20, 2025 •

edited

Loading

Uh oh!

akocbek commented Nov 20, 2025

Uh oh!

mounicatellabati commented Nov 20, 2025

Uh oh!

mounicatellabati commented Nov 21, 2025

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Nov 21, 2025

Uh oh!

ocofaigh Nov 21, 2025

Uh oh!

ocofaigh Nov 21, 2025

Uh oh!

ocofaigh Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

refactor: ignoring parameter cloud_monitoring_connected_instance and updating the description. #354

Uh oh!

Conversation

mounicatellabati commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

mounicatellabati commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akocbek commented Nov 20, 2025

Uh oh!

mounicatellabati commented Nov 20, 2025

Uh oh!

mounicatellabati commented Nov 21, 2025

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Nov 21, 2025

Uh oh!

ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

ocofaigh Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mounicatellabati commented Nov 19, 2025 •

edited

Loading

mounicatellabati commented Nov 20, 2025 •

edited

Loading