Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Dec 8, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Dec 8, 2025
@jor2 jor2 requested a review from akocbek as a code owner December 8, 2025 10:06
@jor2
Copy link
Member Author

jor2 commented Dec 8, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Updated the Fully configurable flavor short_description to follow the recommended format that begins with "Ideal for", making it consistent with IBM Cloud catalog standards.
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

ibm_catalog.json Outdated
"label": "Fully configurable",
"name": "fully-configurable",
"index": 1,
"short_description": "Ideal for users who want SCC Workload Protection with full configuration control, including optional Cloud Logs, Cloud Monitoring, and Activity Tracker integration.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be consistent with what we have in other DAs. Fully configurable variations should say:
"Ideal for users who want flexibility with a reliable starting point."

Jordan-Williams2 and others added 2 commits December 10, 2025 13:32
Added a period to the end of the short description for consistency.
@ocofaigh ocofaigh merged commit 1194b4a into main Dec 10, 2025
@ocofaigh ocofaigh deleted the fix-hooks branch December 10, 2025 15:07
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants