-
Notifications
You must be signed in to change notification settings - Fork 2
fix: pre-commit issues #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Updated the Fully configurable flavor short_description to follow the recommended format that begins with "Ideal for", making it consistent with IBM Cloud catalog standards.
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
ibm_catalog.json
Outdated
| "label": "Fully configurable", | ||
| "name": "fully-configurable", | ||
| "index": 1, | ||
| "short_description": "Ideal for users who want SCC Workload Protection with full configuration control, including optional Cloud Logs, Cloud Monitoring, and Activity Tracker integration.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets be consistent with what we have in other DAs. Fully configurable variations should say:
"Ideal for users who want flexibility with a reliable starting point."
Added a period to the end of the short description for consistency.
|
🎉 This PR is included in version 1.16.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers