Skip to content

fix: pre-commit issues #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocofaigh merged 4 commits into from
Dec 10, 2025
Merged

fix: pre-commit issues #360

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0260d5
fix: pre-commit issues
Dec 8, 2025
77ed49d
fix: update flavor short_description to start with "Ideal for"
Dec 9, 2025
e862a0b
fix: update flavor short_description to start with "Ideal for"
Dec 10, 2025
81f7a77
Fix punctuation in short description
jor2 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 8 files
+11 −1 commonRenovateConfig.json
+1 −1 da-assets/da-dependency-updater/requirements.txt
+1 −1 module-assets/.pre-commit-config.yaml
+3 −0 module-assets/ci/.typos.toml
+3 −3 module-assets/ci/install-deps.sh
+92 −13 module-assets/ci/validateIbmCatalogJson.py
+1 −1 scripts/iks-api-key-reset/reset_iks_api_key.sh
+1 −1 tests/go.mod
8 changes: 7 additions & 1 deletion ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"label": "Fully configurable",
"name": "fully-configurable",
"index": 1,
"short_description": "Ideal for users who want SCC Workload Protection with full configuration control, including optional Cloud Logs, Cloud Monitoring, and Activity Tracker integration.",
Copy link
Contributor

@ocofaigh ocofaigh Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be consistent with what we have in other DAs. Fully configurable variations should say:
"Ideal for users who want flexibility with a reliable starting point."

"working_directory": "solutions/fully-configurable",
"install_type": "fullstack",
"dependency_version_2": true,
Expand Down Expand Up @@ -480,7 +481,12 @@
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment"
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": [
"hcl"
]
}
}
}
],
Expand Down