Full chain of deploy added #208
Conversation
|
Dropped a few comments, let's also add a README.md to explain the flow of this example |
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
See comments. I guess this depends on other PRs to be merged first. I assume the new example can only be run on an enterprise account? If so, can you rename the example: complete -> enterprise
examples/complete/main.tf
Outdated
| } | ||
|
|
||
| module "scc_wp_config_aggregator" { | ||
| source = "terraform-ibm-modules/scc-wp-config-aggregator/ibm" |
There was a problem hiding this comment.
This syntax is wrong for using a submodule. And you should add the version too
There was a problem hiding this comment.
let's check the submodule syntax together
examples/complete/main.tf
Outdated
There was a problem hiding this comment.
revert this change. You are removing it
examples/complete/variables.tf
Outdated
There was a problem hiding this comment.
revert this change. You are removing it
examples/enterprise/main.tf
Outdated
| } | ||
|
|
||
| module "trusted_profiles" { | ||
| source = "../../../terraform-ibm-trusted-profile/examples/enterprise" |
There was a problem hiding this comment.
we'll fix this references once we have clarity from IBM experts
examples/enterprise/main.tf
Outdated
|
|
||
| } | ||
| module "config_aggregator" { | ||
| source = "../../../terraform-ibm-app-configuration/modules/config_aggregator" |
There was a problem hiding this comment.
we'll fix this references once we have clarity from IBM experts
…nd delete the trusted profile examples calling
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Few more comments, but there may be more required changes after the trusted profile PR is merged
|
/run pipeline |
|
🎉 This PR is included in version 1.5.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 participants
Description
Added a full chain of deploy - resource group - workload protection - app config - config aggregator - trusted profiles and trusted profile templates.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers