Skip to content

Conversation

@vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Aug 15, 2025

Description

Split monolith observability DA into 3 separate DA's.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17 vkuma17 requested review from akocbek and shemau as code owners August 15, 2025 15:28
@vkuma17 vkuma17 marked this pull request as draft August 15, 2025 15:29
@vkuma17 vkuma17 marked this pull request as ready for review August 21, 2025 21:23
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 21, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 21, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. We also need to wait for terraform-ibm-modules/terraform-ibm-app-configuration#269 to be merged and new released published so I suggest you mark this PR as draft until that is ready

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 25, 2025

my bad @ocofaigh . This PR was supposed to be in draft state only. By mistake, it was made ready for review

@vkuma17 vkuma17 marked this pull request as draft August 25, 2025 12:25
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.10.0 of AppConfig should be published soon - please update PR to use this

@vkuma17 vkuma17 marked this pull request as ready for review August 25, 2025 15:37
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 25, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 25, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the diagram is missing Cloud Logs

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have 2 diagrams? reference-architecture/scc.svg and scc.svg ?

@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 25, 2025

/run pipeline

1 similar comment
@vkuma17
Copy link
Contributor Author

vkuma17 commented Aug 25, 2025

/run pipeline

@ocofaigh ocofaigh merged commit cac6e1c into main Aug 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the split-obs branch August 25, 2025 19:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants