- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
refactor: Split monolith observability DA #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /run pipeline | 
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. We also need to wait for terraform-ibm-modules/terraform-ibm-app-configuration#269 to be merged and new released published so I suggest you mark this PR as draft until that is ready
| my bad @ocofaigh . This PR was supposed to be in draft state only. By mistake, it was made ready for review | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.10.0 of AppConfig should be published soon - please update PR to use this
| /run pipeline | 
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh the diagram is missing Cloud Logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have 2 diagrams? reference-architecture/scc.svg and scc.svg ?
| /run pipeline | 
    
      
        1 similar comment
      
    
  
    | /run pipeline | 
| 🎉 This PR is included in version 1.11.0 🎉 The release is available on: 
 Your semantic-release bot 📦🚀 | 
Description
Split monolith observability DA into 3 separate DA's.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers